[Python-Dev] [Python-checkins] cpython (2.7): Fix test_fcntl to run properly on systems that do not support the flags (original) (raw)

Nick Coghlan ncoghlan at gmail.com
Mon Nov 25 09:46:26 CET 2013

On 25 Nov 2013 14:46, "gregory.p.smith" <python-checkins at python.org> wrote:

http://hg.python.org/cpython/rev/cac7319c5972 changeset: 87537:cac7319c5972 branch: 2.7 parent: 87534:3981e57a7bdc user: Gregory P. Smith <greg at krypto.org> date: Mon Nov 25 04:45:27 2013 +0000 summary: Fix testfcntl to run properly on systems that do not support the flags used in the "does the value get passed in properly" test. files: Lib/test/testfcntl.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Lib/test/testfcntl.py b/Lib/test/testfcntl.py --- a/Lib/test/testfcntl.py +++ b/Lib/test/testfcntl.py @@ -113,7 +113,10 @@ self.skipTest("FNOTIFY or DNMULTISHOT unavailable") fd = os.open(os.path.dirname(os.path.abspath(TESTFN)), os.O_RDONLY) try: + # This will raise OverflowError if issue1309352 is present. fcntl.fcntl(fd, cmd, flags) + except IOError: + pass # Running on a system that doesn't support these flags. finally: os.close(fd)

Raising a skip is generally preferred to marking a test that can't be executed as passing.

Cheers, Nick.

-- Repository URL: http://hg.python.org/cpython

Python-checkins mailing list Python-checkins at python.org https://mail.python.org/mailman/listinfo/python-checkins -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20131125/7d76165a/attachment.html>

More information about the Python-Dev mailing list