[Python-Dev] [Python-checkins] cpython: Issue #18810: Be optimistic with stat calls when seeing if a directory (original) (raw)

Nick Coghlan ncoghlan at gmail.com
Sat Oct 19 16:42:30 CEST 2013


On 19 October 2013 23:54, Brett Cannon <brett at python.org> wrote:

I don't follow this logic. There's now not even an existence check for the base name, so it reads to me like we will look for all the possible init file extensions even if there's no directory with an appropriate name.

What am I missing? if cachemodule in cache:, the line above the pathjoin() call and the guard that blocks the entire package search.

Ah, that's what I get for reviewing diffs on my phone and hence not looking up the full context :)

Thanks for the clarification.

Cheers, Nick.

-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia



More information about the Python-Dev mailing list