[Python-Dev] [Python-checkins] cpython: Issue #19330: Handle the no-docstrings case in tests (original) (raw)

Nick Coghlan ncoghlan at gmail.com
Sun Oct 27 02:34:27 CET 2013

On 27 Oct 2013 04:16, "Serhiy Storchaka" <storchaka at gmail.com> wrote:

26.10.13 20:32, Nick Coghlan написав(ла):

On 27 October 2013 01:10, Serhiy Storchaka <storchaka at gmail.com> wrote:

26.10.13 15:50, Stefan Krah написав(ла):

nick.coghlan <python-checkins at python.org> wrote:

http://hg.python.org/cpython/rev/a9bbc2d0c1dc -HAVEDOCSTRINGS = (checkimpldetail(cpython=False) or - sys.platform == 'win32' or - sysconfig.getconfigvar('WITHDOCSTRINGS')) +# Rather than trying to enumerate all the cases where docstrings may be +# disabled, we just check for that directly + +def checkdocstrings(): + """Just used to check if docstrings are enabled""" + +HAVEDOCSTRINGS = (checkdocstrings.doc is not None) requiresdocstrings = unittest.skipUnless(HAVEDOCSTRINGS,

I think that does not detect --without-doc-strings (i.e. the C docstrings are empty). Indeed. HAVEDOCSTRINGS was introduced to skip tests for the C docstrings. Python docstrings tests are skipped if sys.flags.optimize >= 2. That's extraordinarily confusing, especially when Serhiy suggested I use the flag when testing a pure Python module. I'm sorry for misleading you.

And my apologies for going ahead and assuming I understood what the flag was for rather than seeking clarification.

I'll put together a patch to split it into two flags for the different meanings.

Cheers, Nick.

Python-Dev mailing list Python-Dev at python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20131027/c5b501db/attachment.html>

More information about the Python-Dev mailing list