[Python-Dev] [Python-checkins] cpython: Issue #19976: Argument Clinic METH_NOARGS functions now always (original) (raw)
Stefan Krah stefan at bytereef.org
Sat Jan 4 21:00:09 CET 2014
- Previous message: [Python-Dev] Bug? http.client assumes iso-8859-1 encoding of HTTP headers
- Next message: [Python-Dev] [Python-checkins] cpython: Issue #19976: Argument Clinic METH_NOARGS functions now always
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Probably Rietveld did not send mail, so I mention my review comments again:
larry.hastings <python-checkins at python.org> wrote:
+#ifdef GNUC +#define PyUNUSED(name) unused ## name attribute((unused)) +#else +#define PyUNUSED(name) unused ## name +#endif +
The Intel compiler defines GNUC but chokes on the attribute().
This works:
#if defined(GNUC) && !defined(__INTEL_COMPILER)
+picklePicklerclearmemo(PyObject *self, PyObject *PyUNUSED(ignored))
I'm not a native speaker, but UNUSED(ignored) reads strange to me. I would prefer UNUSED(args).
Stefan Krah
- Previous message: [Python-Dev] Bug? http.client assumes iso-8859-1 encoding of HTTP headers
- Next message: [Python-Dev] [Python-checkins] cpython: Issue #19976: Argument Clinic METH_NOARGS functions now always
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]