[Python-Dev] [Python-checkins] cpython (2.7): Issue #22773: fix failing test with old readline versions due to issue #19884. (original) (raw)
Antoine Pitrou solipsis at pitrou.net
Tue Nov 4 15:12:36 CET 2014
- Previous message: [Python-Dev] [Python-checkins] cpython (2.7): Issue #22773: fix failing test with old readline versions due to issue #19884.
- Next message: [Python-Dev] Dinamically set __call__ method
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, 04 Nov 2014 09:58:29 -0400 Benjamin Peterson <benjamin at python.org> wrote:
On Tue, Nov 4, 2014, at 09:55, antoine.pitrou wrote: > https://hg.python.org/cpython/rev/eba6e68e818c > changeset: 93382:eba6e68e818c > branch: 2.7 > parent: 93379:e54d0b197c82 > user: Antoine Pitrou <solipsis at pitrou.net> > date: Tue Nov 04 14:52:10 2014 +0100 > summary: > Issue #22773: fix failing test with old readline versions due to issue > #19884. > > files: > Lib/test/testreadline.py | 4 ++++ > Modules/readline.c | 3 +++ > 2 files changed, 7 insertions(+), 0 deletions(-) > > > diff --git a/Lib/test/testreadline.py b/Lib/test/testreadline.py > --- a/Lib/test/testreadline.py > +++ b/Lib/test/testreadline.py > @@ -43,6 +43,10 @@ > > > class TestReadline(unittest.TestCase): > + > + @unittest.skipIf(readline.READLINEVERSION < 0x0600 Shouldn't this use the runtime version?
I suppose in most libreadline deployments it shouldn't make a difference (you usually get it through your Linux distro; other OSes use non-GNU replacements, if any).
Regards
Antoine.
- Previous message: [Python-Dev] [Python-checkins] cpython (2.7): Issue #22773: fix failing test with old readline versions due to issue #19884.
- Next message: [Python-Dev] Dinamically set __call__ method
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]