[Python-Dev] [Python-checkins] cpython: Issue #23152: Implement _Py_fstat() to support files larger than 2 GB on (original) (raw)

Brett Cannon brett at python.org
Sat Feb 21 23:11:54 CET 2015

On Sat Feb 21 2015 at 4:23:16 PM Ben Hoyt <benhoyt at gmail.com> wrote:

When merging some changes while working on scandir, I noticed a minor issue with this commit:

https://hg.python.org/cpython/rev/4f6f4aa0d80f The definition of "struct win32stat" has been moved to fileutils.h and renamed to "struct Pystatstruct", which is fine -- however, the old "struct win32stat" definition is still present (but unused) in posixmodule.c. So I think the old "struct win32stat { ... }" definition can simply be removed from posixmodule.c now.

I don't think win32_stat is part of the stable ABI so as long as everything keeps working then I don't see why it needs to stick around.

Also, unrelated to this commit, I notice the Pyattributedatatostat function (was attributedatatostat) can't fail and always returns 0, and all callers ignore its return value anyway. Can it be changed to return void?

Don't see why not since it's a private API. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20150221/d6fccb6d/attachment.html>

More information about the Python-Dev mailing list