[Python-Dev] PEP 485 isclose() implementation review requested (original) (raw)

Christian Heimes christian at python.org
Mon May 18 18:00:51 CEST 2015


-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

On 2015-05-18 17:49, Chris Barker wrote:

Thanks Cristian, that clears up a couple things -- got it compiling without warning.

But I also discovered that I must have not pushed the latest copy yesterday. It's on a machine at home -- I'll push it tonight. But the copy on gitHub now is mostly good -- I think the only changes are handling the docsstrings better and some more/better tests.

You're welcome!

Does your latest patch handle NaN, too? I only noticed infinity checks but no explicit check for NaN.

Christian

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJVWgyrAAoJEIZoUkkhLbaJhBsH/3gH7Z1+otWwR6hIYjNU4OjK xjPmGeypisU6UDxfQa+lIHg1rEmyxlSbkXtn2DYysw9CMentK/XclF8GzWAA/ySV m0UE4+hzcWB7fsOLgbCxQKfNTEM/jp7D2z3qIZTknEecHENx552AaEfTXRTWQKHK QLh0sLA3QrOzUkOf+EXJQHlYvxf+F71PVyfOX8/m3XHhaQrpb70AGktsUPRDN3yc blY6SSQoV1uhw+/crqz34BoPGipAkZdq9abyz4Ja0adC8hT++7rbVldFdsrDIPdQ MX30atV+ZQ2Mb5NqJkmEjCKF5uXvwvlP8ijgz5nZKZ9db+9Z8YS0/e7UrPb85uM= =7N7z -----END PGP SIGNATURE-----



More information about the Python-Dev mailing list