[Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to (original) (raw)
Yury Selivanov yselivanov.ml at gmail.com
Tue May 26 07:33:46 CEST 2015
- Previous message (by thread): [Python-Dev] Unable to build regex module against Python 3.5 32-bit
- Next message (by thread): [Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2015-05-26 12:26 AM, Terry Reedy wrote:
+ try: + encoding, lines = detectencoding(buffer.readline) + buffer.seek(0) + text = TextIOWrapper(buffer, encoding, linebuffering=True) + text.mode = 'r' + return text + except: + buffer.close() + raise Please do not add bare 'except:'. If you mean 'except BaseException:', say so.
try..finally would be even better.
Yury
- Previous message (by thread): [Python-Dev] Unable to build regex module against Python 3.5 32-bit
- Next message (by thread): [Python-Dev] [Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]