[Python-Dev] type(obj) vs. obj.class (original) (raw)

Chris Angelico rosuav at gmail.com
Sun Oct 18 20:41:44 EDT 2015

On Mon, Oct 19, 2015 at 11:35 AM, David Mertz <mertz at gnosis.cx> wrote:

That's interesting about the self.full variable slowing it down, I think I'm not surprised (but obviously it depends on just how it's used). But one can also simply define RingBuffer.isfull() using self.max==len(self.data) if you prefer that approach. I doubt myringbuffer.isfull() is something you need to call in an inner loop.

That said, I think my implementation of RingBuffer would probably look more like (completely untested): class RingBuffer(object): def init(self, sizemax): self.data = [None] * sizemax self.sizemax = sizemax self.used = 0 self.cur = 0 def append(self, val): self.data[self.cur] = val self.cur = (self.cur+1) % self.sizemax self.used = max(self.used, self.cur+1) def isfull(self): self.used == self.sizemax Feel free to try this version against whatever benchmark you have in mind.

What does this provide that collections.deque(maxlen=size_max) doesn't? I'm a little lost.

ChrisA

More information about the Python-Dev mailing list