[Python-Dev] PEP 8 updated on whether to break before or after a binary update (original) (raw)

Guido van Rossum guido at python.org
Fri Apr 15 13:06:00 EDT 2016

On Fri, Apr 15, 2016 at 10:03 AM, Victor Stinner <victor.stinner at gmail.com> wrote:

Hum.

if (width == 0 and height == 0 and color == 'red' and emphasis == 'strong' or highlight > 100): raise ValueError("sorry, you lose") Please remove one space to vertically align "and" operators with the opening parenthesis: if (width == 0 and height == 0 and color == 'red' and emphasis == 'strong' or highlight > 100): raise ValueError("sorry, you lose") (I'm not sure that the difference is obvious in a mail client, you need a fixed width font which is not the case in my Gmail editor.)

I can see it perfectly fin and I disagree.

It helps to visually see that the multiline test and the raise instruction are in two different blocks.

(Moreover, the pep8 checks of OpenStack simply reject such syntax, but I cannot use this syntax anymore :-))

That's why that tool shouldn't be named after the PEP. See https://github.com/PyCQA/pycodestyle/issues/466

-- --Guido van Rossum (python.org/~guido) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20160415/0df87464/attachment.html>

More information about the Python-Dev mailing list