[Python-Dev] Inconsistency of PyModule_AddObject() (original) (raw)
Hrvoje Niksic hrvoje.niksic at avl.com
Wed Apr 27 08:31:37 EDT 2016
- Previous message (by thread): [Python-Dev] Inconsistency of PyModule_AddObject()
- Next message (by thread): [Python-Dev] Inconsistency of PyModule_AddObject()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/27/2016 09:14 AM, Serhiy Storchaka wrote:
There are three functions (or at least three documented functions) in C API that "steals" references: PyListSetItem(), PyTupleSetItem() and PyModuleAddObject(). The first two "steals" references even on failure, and this is well known behaviour. But PyModuleAddObject() "steals" a reference only on success. There is nothing in the documentation that points on this.
This inconsistency has caused bugs (or, more fairly, potential leaks) before, see http://bugs.python.org/issue1782
Unfortunately, the suggested Python 3 change to PyModule_AddObject was not accepted.
1. Add a new function PyModuleAddObject2(), that steals a reference even on failure.
This sounds like a good idea, except the name could be prettier :), e.g. PyModule_InsertObject. PyModule_AddObject could be deprecated.
Hrvoje
- Previous message (by thread): [Python-Dev] Inconsistency of PyModule_AddObject()
- Next message (by thread): [Python-Dev] Inconsistency of PyModule_AddObject()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]