[Python-Dev] Review request: issue 27350, compact ordered dict (original) (raw)
Maciej Fijalkowski fijall at gmail.com
Wed Aug 10 11:06:30 EDT 2016
- Previous message (by thread): [Python-Dev] Review request: issue 27350, compact ordered dict
- Next message (by thread): [Python-Dev] Review request: issue 27350, compact ordered dict
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello everyone.
I did do only a cursory look on that one, but I would like to reiterate that this gives huge benefits in general and we measured nice speedups on pypy (where all the dicts are ordered forever):
- you can essentially kill OrderedDict or make it almost OrderedDict = dict (in pypy it's a simple dict subclass that has one or two extra things that OrderedDict has in the API)
- there are nice speedups
- the C version of OrderedDict can be killed
- it saves memory, on 64bit by quite a bit (not everyone stores more than 4bln items in a dictionary)
- it solves the problem of tests relying on order in dictionaries
In short, it has no downsides
On Tue, Aug 9, 2016 at 3:12 PM, INADA Naoki <songofacandy at gmail.com> wrote:
Hi, devs.
I've implemented compact and ordered dictionary [1], which PyPy implemented in 2015 [2]. Since it is my first large patch, I would like to have enough time for review cycle by Python 3.6 beta1. Could someone review it? [1] http://bugs.python.org/issue27350 [2] https://morepypy.blogspot.jp/2015/01/faster-more-memory-efficient-and-more.html -- INADA Naoki <songofacandy at gmail.com>
Python-Dev mailing list Python-Dev at python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/fijall%40gmail.com
- Previous message (by thread): [Python-Dev] Review request: issue 27350, compact ordered dict
- Next message (by thread): [Python-Dev] Review request: issue 27350, compact ordered dict
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]