[Python-Dev] PySlice_GetIndicesEx annd stable ABI: bikeshedding (original) (raw)

Armin Rigo armin.rigo at gmail.com
Thu Dec 22 05:16:24 EST 2016

Hi Serhiy,

On 21 December 2016 at 15:51, Serhiy Storchaka <storchaka at gmail.com> wrote:

The code

if (PySliceGetIndicesEx(item, length, &start, &stop, &step, &slicelength) < 0) return -1; should be replaced with if (foo(item, &start, &stop, &step) < 0) return -1; slicelength = bar(&start, &stop, step, length);

As far as I can tell, as written, this change would not fix anything. Shouldn't it be along the following lines instead?

if (foo(item, &start, &stop, &step) < 0)
    return -1;
length = PyList_GET_SIZE(mylist);   /* <= after foo() */
slicelength = bar(&start, &stop, &step, length);

A bientôt,

Armin.

More information about the Python-Dev mailing list