[Python-Dev] Update PEP 7 to require curly braces in C (original) (raw)

francismb francismb at email.de
Tue Jan 19 15:22:27 EST 2016


Hi Brett,

On 01/19/2016 12:20 AM, Brett Cannon wrote:

On Sun, 17 Jan 2016 at 11:10 Brett Cannon <brett at python.org> wrote:

While doing a review of http://bugs.python.org/review/26129/ I asked to have curly braces put around all if statement bodies. Serhiy pointed out that PEP 7 says curly braces are optional: https://www.python.org/dev/peps/pep-0007/#id5. I would like to change that.

My argument is to require them to prevent bugs like the one Apple made with OpenSSL about two years ago: https://www.imperialviolet.org/2014/02/22/applebug.html. Skipping the curly braces is purely an aesthetic thing while leaving them out can lead to actual bugs. Anyone object if I update PEP 7 to remove the optionality of curly braces in PEP 7?

What about about a code formatter bot ? (new workflow). If one just could agree, then those reviews should just disappear (?).

Regards, francis



More information about the Python-Dev mailing list