[Python-Dev] PEP 509: Add a private version to dict (original) (raw)

Brett Cannon brett at python.org
Wed Jan 20 13:22:50 EST 2016

On Wed, 20 Jan 2016 at 10:11 Yury Selivanov <yselivanov.ml at gmail.com> wrote:

On 2016-01-18 5:43 PM, Victor Stinner wrote: > Is someone opposed to this PEP 509? > > The main complain was the change on the public Python API, but the PEP > doesn't change the Python API anymore. > > I'm not aware of any remaining issue on this PEP.

Victor, I've been experimenting with the PEP to implement a per-opcode cache in ceval loop (I'll share my progress on that in a few days). This allows to significantly speedup LOADGLOBAL and LOADMETHOD opcodes, to the point, where they don't require any dict lookups at all. Some macro-benchmarks (such as chameleonv2) demonstrate impressive ~10% performance boost.

Ooh, now my brain is trying to figure out the design of the cache. :)

I rely on your dict->maversion to implement cache invalidation. However, besides guarding against version change, I also want to guard against the dict being swapped for another dict, to avoid situations like this:

def foo(): print(bar) exec(foo.code, {'bar': 1}, {}) exec(foo.code, {'bar': 2}, {}) What I propose is to add a pointer "maextra" (same 64bits), which will be set to NULL for most dict instances (instead of maversion). "maextra" can then point to a struct that has a globally unique dict ID (uint64), and a version tag (unit64). A macro like PyDictGETID and PyDictGETVERSION could then efficiently fetch the version/unique ID of the dict for guards. "maextra" would also make it easier for us to extend dicts in the future.

Why can't you simply use the id of the dict object as the globally unique dict ID? It's already globally unique amongst all Python objects which makes it inherently unique amongst dicts. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20160120/592786ef/attachment.html>

More information about the Python-Dev mailing list