[Python-Dev] Bug in build system for cross-platform builds (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Mon Mar 14 08:41:18 EDT 2016
- Previous message (by thread): [Python-Dev] Bug in build system for cross-platform builds
- Next message (by thread): [Python-Dev] Bug in build system for cross-platform builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 14 March 2016 at 13:04, Gregory P. Smith <greg at krypto.org> wrote:
They should not be regenerated every build, if they are, that seems like a bug in the makefile to me (or else the timestamp checks that make does vs how your code checkout happened). Having them checked in is convenient for cross builds as it is one less thing that needs a build-host-arch build.
It's also two less things to go wrong for folks just wanting to work on the 99.9% of CPython that is neither the Grammar file nor importlib._bootstrap.
I'm trying to remember the problem I was solving in making freezeimportlib.o explicitly depend on the Makefile (while cursing past me for not writing it down in the commit message), and I think the issue was that it wasn't correctly picking up changes to the builtin module list. If that's right, then fixing the dependency to be on "$(srcdir)/Makefile.pre.in" instead of the generated Makefile should keep it from getting confused in the cross-compilation scenario, and also restore the behaviour of using the checked in copy rather than rebuilding it just because you ran "./configure".
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message (by thread): [Python-Dev] Bug in build system for cross-platform builds
- Next message (by thread): [Python-Dev] Bug in build system for cross-platform builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]