[Python-Dev] file system path protocol PEP (original) (raw)

Koos Zevenhoven k7hoven at gmail.com
Wed May 11 19:49:30 EDT 2016

On Thu, May 12, 2016 at 2:05 AM, Ethan Furman <ethan at stoneleaf.us> wrote:

On 05/11/2016 03:13 PM, Brett Cannon wrote:

If [...] I would drop os.path changes and make os.fspath() do what Ethan and Koos have suggested and simply pass through without checks

whatever path.fspath() returned if the argument wasn't str or bytes. Not to derail the conversation too much, as I know we're all getting burned out on the topic, but that last bit is not accurate: my druthers are to have fspath be able to return str /or/ bytes, and if anything else comes from the object in question an exception must be raised. Maybe a word got lost between your thoughts and your fingers -- happens to me all the time. :)

Yes. This would also be equivalent to my fspath(path, type_constraint=(str,bytes)). And if the compromise I mentioned about the rejecting (by default or optionally) is lifted, the keyword argument would not be needed. I might be ok with throwing away the isinstance check on the return value of fspath() if it has significant impact on performance in realistic cases (with DirEntry most likely, I suppose), but I doubt it.

-- Koos

-- Ethan

Python-Dev mailing list Python-Dev at python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/k7hoven%40gmail.com

More information about the Python-Dev mailing list