[Python-Dev] cpython (3.6): replace usage of Py_VA_COPY with the (C99) standard va_copy (original) (raw)
Benjamin Peterson benjamin at python.org
Thu Sep 22 02:01:01 EDT 2016
- Previous message (by thread): [Python-Dev] cpython (3.6): replace usage of Py_VA_COPY with the (C99) standard va_copy
- Next message (by thread): [Python-Dev] OpenIndiana and Solaris support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Sep 21, 2016, at 02:06, Christian Heimes wrote:
On 2016-09-21 05:39, benjamin.peterson wrote: > https://hg.python.org/cpython/rev/278b21d8e86e > changeset: 103977:278b21d8e86e > branch: 3.6 > parent: 103975:d31b4de433b7 > user: Benjamin Peterson <benjamin at python.org> > date: Tue Sep 20 20:39:33 2016 -0700 > summary: > replace usage of PyVACOPY with the (C99) standard vacopy
Thanks! Coverity has been complaining about PyVACOPY() for a long time. Your change may cause a memory leak on some platforms. You must vaend() a vacopy() region:
Yep. Thanks for fixing that. I'm not actually aware of any platform where va_end() frees anything, but it's the right thing to do.
- Previous message (by thread): [Python-Dev] cpython (3.6): replace usage of Py_VA_COPY with the (C99) standard va_copy
- Next message (by thread): [Python-Dev] OpenIndiana and Solaris support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]