[Python-Dev] [bpo-30421]: Pull request review (original) (raw)

Terry Reedy tjreedy at udel.edu
Mon Aug 28 12:46:05 EDT 2017

On 8/28/2017 3:42 AM, Robert Schindler wrote:

Hello,

In May, I submitted a pull request that extends the functionality of argparse.ArgumentParser.

The argparse maintainer, bethard (Peter Bethard), was not added to the nosy list. And he does not seem to have been active lately -- his bpo profile does not list a github name.

To do so, I followed the steps described in the developers guide.

According to [1], I already pinged at GitHub but got no response. The next step seems to be writing to this list. I know that nobody is payed for reviewing submissions, but maybe it just got overlooked? You can find the pull request at [2].

[1] https://docs.python.org/devguide/pullrequest.html#reviewing [2] https://github.com/python/cpython/pull/1698

Some core developer has to decide if the new feature should be added, and if so, what the API should be. If Peter is not doing that, I don't know who will. It is possible that the current design is intentional, rather than an oversight. It does not make too much sense to review the implementation (the PR) until the design decisions are made. In this case, the PR adds a feature not discussed on the bpo issue.

-- Terry Jan Reedy

More information about the Python-Dev mailing list