[Python-Dev] PEP 7 and braces { .... } on if (original) (raw)

Rob Cliffe rob.cliffe at btinternet.com
Tue Jun 6 20:42:23 EDT 2017

On 07/06/2017 01:30, Barry Warsaw wrote:

On Jun 05, 2017, at 08:41 AM, Serhiy Storchaka wrote:

the example above), and the following code is enough readable:

if (PyErrWarnFormat(PyExcDeprecationWarning, 1, "invalid escape sequence '\%c'", *firstinvalidescape) < 0) { PyDECREF(result); return NULL; } My rationale for placing the opening brace on a separate line, indented to under the if instead of hanging is that it's easier to miss the opening brace in the example you posted above. Visually I (we?) tend to have a harder time recognizing characters sitting way out to the right. On Jun 05, 2017, at 08:19 AM, Ethan Furman wrote: I would format that as: if (PyErrWarnFormat( PyExcDeprecationWarning, 1, "invalid escape sequence '\%c'", *firstinvalidescape) < 0) { PyDECREF(result); return NULL; } In this case I'd still indent the opening brace to under the if. The mismatched indentation between the open and close braces is jarring to me. FWIW I feel exactly the same. Rob Cliffe

More information about the Python-Dev mailing list