[Python-Dev] Buildbot report (almost July) (original) (raw)

Victor Stinner victor.stinner at gmail.com
Thu Jun 29 16:04:06 EDT 2017

2017-06-29 19:13 GMT+02:00 Terry Reedy <tjreedy at udel.edu>:

How about compiler warnings (and errors)?

That would be nice to have, but I don't have the bandwidth to handle this goal.

When I compile on Windows, there are a boatload of orange-yellow warnings. Some are about using a deprecated featured; some about dodgy casts; some (I presume) about other things. Should 'no warnings' be a goal?

Last years, I tried to fix a few integer downcast warnings on Windows 64-bit, but they are still a few ones. It's not easy to distinguish warnings from real bugs (integer overflow).

There are a few open issues about Windows 64-bit warnings.

Segev Finer just wrote an interesting but big PR: https://github.com/python/cpython/pull/2492

The deprecated warnings is another interesting topic :-)

I believe you once fixed some, but new commits added more. Could 'no additional warnings' be a CI requirement for merging? I expect that a new "How to avoid compiler warnings on Windows" section of the devguide would be needed.

My policy is more to start by fixing all warnings, before starting to check for regressions.

I began by fixing the most common test failures, then references leaks, and now memory leaks. So it becomes much simpler to check for regressions on these checks.

Victor

More information about the Python-Dev mailing list