[Python-Dev] GH-NNNN vs #NNNN in merge commit (original) (raw)
Victor Stinner victor.stinner at gmail.com
Thu Jan 25 06:26:10 EST 2018
- Previous message (by thread): [Python-Dev] GH-NNNN vs #NNNN in merge commit
- Next message (by thread): [Python-Dev] GH-NNNN vs #NNNN in merge commit
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
GH prefix avoids confusion between bugs.python.org and GitHub, but GitHub generates #xxx in the generated commit message on Merge... Each commit message has to be manually edited. It would be better to get GH automatically.
Victor
Le 25 janv. 2018 11:44, "INADA Naoki" <songofacandy at gmail.com> a écrit :
Hi.
Devguide says: """ Replace the reference to GitHub pull request #NNNN with GH-NNNN. If the title is too long, the pull request number can be added to the message body. """ https://devguide.python.org/gitbootcamp/#accepting-and- merging-a-pull-request But there are more #NNNN than GH-NNNN in commit log. https://github.com/python/cpython/commits/master Where should we go? Encourage GH-NNNN? or abandon it and use default #NNNN? Regards, -- INADA Naoki <songofacandy at gmail.com>
Python-Dev mailing list Python-Dev at python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/ victor.stinner%40gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20180125/4a7dcbfe/attachment.html>
- Previous message (by thread): [Python-Dev] GH-NNNN vs #NNNN in merge commit
- Next message (by thread): [Python-Dev] GH-NNNN vs #NNNN in merge commit
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]