[Python-Dev] GH-NNNN vs #NNNN in merge commit (original) (raw)

Zachary Ware zachary.ware+pydev at gmail.com
Thu Jan 25 13:12:58 EST 2018

On Thu, Jan 25, 2018 at 12:03 PM, Mariatta Wijaya <mariatta.wijaya at gmail.com> wrote:

Of course, we would still need to convince people to install it :)

Right, that's the challenge :) I personally use Chrome (!) and I've been using your Chrome extension, so thank you! However, I don't feel comfortable making this available only for a specific browser user, feels exclusionary to me. Also, sometimes I merge from my phone where there's no chrome extension, (maybe I really shouldn't be doing that?).

A large part of Brett's push for moving to a PR workflow was to be able to merge patches from a tablet on the beach, so I see no reason not to merge from a phone if you can :)

I think the solution should be something not webbrowser specific.

One idea is maybe have a bot to do the squash commit, for example by commenting on GitHub: @merge-bot merge So core devs can do the above instead of pressing the commit button. Any thoughts on this? In the meantime, committers, please try to remember and change the # into GH- :)

+1 to everything here.

-- Zach

More information about the Python-Dev mailing list