[Python-Dev] [Python-checkins] bpo-34239: Convert test_bz2 to use tempfile (#8485) (original) (raw)

Tim Golden mail at timgolden.me.uk
Sun Jul 29 02:04:48 EDT 2018

On 28/07/2018 23:54, Chris Jerdonek wrote:

On Thu, Jul 26, 2018 at 2:05 PM, Tim Golden <webhook-mailer at python.org> wrote:

https://github.com/python/cpython/commit/6a62e1d365934de82ff7c634981b3fbf218b4d5f commit: 6a62e1d365934de82ff7c634981b3fbf218b4d5f branch: master author: Tim Golden <mail at timgolden.me.uk> committer: GitHub <noreply at github.com> date: 2018-07-26T22:05:00+01:00 summary:

bpo-34239: Convert testbz2 to use tempfile (#8485) * bpo-34239: Convert testbz2 to use tempfile testbz2 currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid. This can give rise to race conditions where tests are competing with each other to delete and recreate the file. Per the other thread-- https://mail.python.org/pipermail/python-dev/2018-July/154762.html this seems like a wrong statement of the problem as tests are properly cleaning up after themselves. The leading hypothesis is that unrelated Windows processes are delaying the deletion (e.g. virus scanners).

Thanks, Chris. I'm tracking the other thread and, if needs be, I'll revert this change in favour of whatever other approach is preferred

TJG

More information about the Python-Dev mailing list