[Python-Dev] Policy on refactoring/clean up (original) (raw)
INADA Naoki songofacandy at gmail.com
Tue Jun 26 05:11:16 EDT 2018
- Previous message (by thread): [Python-Dev] Policy on refactoring/clean up
- Next message (by thread): [Python-Dev] Policy on refactoring/clean up
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
FYI, I don't against general refactoring, when I agree it's really make code cleaner, readable.
I against your PR because I didn't feel it really make code cleaner, readable. I already commented about it on the PR. https://github.com/python/cpython/pull/7909#issuecomment-400219905
So it's not problem about general policy about refactoring / clean up. It's just my preference. If Victor and Serhiy prefer the PR, I'm OK to merge it.
Regards,
-- INADA Naoki <songofacandy at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20180626/e273d757/attachment.html>
- Previous message (by thread): [Python-Dev] Policy on refactoring/clean up
- Next message (by thread): [Python-Dev] Policy on refactoring/clean up
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]