[Python-Dev] Remove tempfile.mktemp() (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Tue Mar 19 11:16:21 EDT 2019

On Tue, 19 Mar 2019 15:12:06 +0100 Sebastian Rittau <srittau at rittau.biz> wrote:

Am 19.03.19 um 14:53 schrieb Victor Stinner: > > When I write tests, I don't really care of security, but > NamedTemporaryFile caused me many troubles on Windows: you cannot > delete a file if it's still open in a another program. It's way more > convenient to use tempfile.mktemp(). > > OEXCL, open(tmpname, "wx"), os.open(tmpname, os.OCREAT | os.OEXCL | > os.OWRONLY), etc. can be used to get an error if the file already > exists. > > I agree that for production code where security matters, > tempfile.mktemp() must be avoided. But I would prefer to keep it for > tests.

If there are valid use cases for mktemp(), I recommend renaming it to mknameunsafe() or something equally obvious. [...] Adding a new function and following the deprecation process for the old one should only be a minor inconvenience for existing users that need it, should wake up existing users that should not use it in the first place, and still allows it to be used for relevant use cases.

That would be fine with me.

Regards

Antoine.

More information about the Python-Dev mailing list