[Python-Dev] PEP 590: vectorcall without tp_call (original) (raw)
Petr Viktorin encukou at gmail.com
Wed May 29 09:29:35 EDT 2019
- Previous message (by thread): [Python-Dev] PEP 590: vectorcall without tp_call
- Next message (by thread): [Python-Dev] PEP 590: vectorcall without tp_call
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 5/29/19 2:25 PM, Jeroen Demeyer wrote:
Hello,
I have one implementation question about vectorcall which is not specified in PEP 590: what should happen if a type implements vectorcall (i.e. PyTPFLAGSHAVEVECTORCALL is set) but doesn't set tpcall (i.e. tpcall == NULL)? I see the following possibilities: 1. Ignore this problem/assume that it won't happen. This would be bad, since callable(obj) would be False even though obj() would succeed. 2. Raise SystemError. 3. Automatically set tpcall to PyVectorcallCall. I would vote for 3 since it's the most user-friendly option. There is also no way how it could be wrong: it ensures that tpcall and vectorcall are consistent.
That sounds like a good idea for PyType_FromSpec.
For static types I either wouldn't bother at all, or only check in debug builds and fail with Py_FatalError.
- Previous message (by thread): [Python-Dev] PEP 590: vectorcall without tp_call
- Next message (by thread): [Python-Dev] PEP 590: vectorcall without tp_call
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]