Carlos O'Donell - Re: [COMMITTED] hppa: Remove warnings and fix conformance errors. (original) (raw)

This is the mail archive of the libc-alpha@sourceware.orgmailing list for the glibc project.

• From: "Carlos O'Donell"
• To: Joseph Myers
• Cc: GNU C Library
• Date: Fri, 06 Feb 2015 10:40:54 -0500
• Subject: Re: [COMMITTED] hppa: Remove warnings and fix conformance errors.
• Authentication-results: sourceware.org; auth=none
• References: <54D42481 dot 6080700 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1502060223260 dot 3494 at digraph dot polyomino dot org dot uk> <54D42A00 dot 6070708 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1502061530270 dot 13073 at digraph dot polyomino dot org dot uk>

On 02/06/2015 10:35 AM, Joseph Myers wrote:

On Thu, 5 Feb 2015, Carlos O'Donell wrote:

* sysdeps/unix/sysv/linux/hppa/pthread.h: Include pthread.h. 

No, this is an installed header - you can't do that. Yes, the duplication should be avoided, but that means making the main pthread.h include a bits/ header of which hppa has a special version.

Thanks. I had not noticed this during testing. I'm going to revert the

Normal testing doesn't cover issues of the form "installed header doesn't work when installed" (whether using include_next, or including a new bits/ header that didn't get added to the makefile list of headers to install, or ...). This is one of the issues where it would help for most tests to build with only the headers that get installed rather than with all the header search paths in the glibc source tree used when building the library itself.

I agree. We need CI for glibc to reinstall new glibc and then build binutils, gcc, and glibc over again to look for issues. This is what I normally do.

I still have my eye on a buildbot running in the gcc build farm to handle this kind of thing.

Cheers, Carlos.

• References:
  • [COMMITTED] hppa: Remove warnings and fix conformance errors.
    * From: Carlos O'Donell
  • Re: [COMMITTED] hppa: Remove warnings and fix conformance errors.
    * From: Joseph Myers
  • Re: [COMMITTED] hppa: Remove warnings and fix conformance errors.
    * From: Carlos O'Donell
  • Re: [COMMITTED] hppa: Remove warnings and fix conformance errors.
    * From: Joseph Myers