Adhemerval Zanella - Re: [PATCH] powerpc: drop R_PPC_REL16 check (original) (raw)

This is the mail archive of the libc-alpha@sourceware.orgmailing list for the glibc project.

• From: Adhemerval Zanella
• To: libc-alpha at sourceware dot org
• Date: Mon, 09 Feb 2015 11:38:20 -0200
• Subject: Re: [PATCH] powerpc: drop R_PPC_REL16 check
• Authentication-results: sourceware.org; auth=none
• References: <54D124CA dot 90609 at linux dot vnet dot ibm dot com>

If no one opposes, I will commit it today.

On 03-02-2015 17:43, Adhemerval Zanella wrote:

Current minimum support binutils (2.22) supports R_PPC_REL16 as default, so no need to extra configure checks.

Checked on powerpc32-fpu.

--

* sysdeps/powerpc/powerpc32/configure.ac: Remove R_PPC_REL16 check.
* sysdeps/powerpc/powerpc32/configure: Regenerated.

--

diff --git a/sysdeps/powerpc/powerpc32/configure b/sysdeps/powerpc/powerpc32/configure index fe5a792..29cfd53 100644 --- a/sysdeps/powerpc/powerpc32/configure +++ b/sysdeps/powerpc/powerpc32/configure @@ -1,34 +1,6 @@

This file is generated from configure.ac by Autoconf. DO NOT EDIT!

Local configure fragment for sysdeps/powerpc/powerpc32.

-# See whether gas has R_PPC_REL16 relocs. -{ asecho"as_echo "ase​cho"as_me:${as_lineno-$LINENO}: checking for R_PPC_REL16 gas support" >&5 -$as_echo_n "checking for R_PPC_REL16 gas support... " >&6; } -if ${libc_cv_ppc_rel16+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.s <<\EOF - .text - addis 11,30,_GLOBAL_OFFSET_TABLE_-.@ha -EOF -if { ac_try='${CC-cc} -c $CFLAGS conftest.s 1>&5' - { { eval echo ""$as_me":${as_lineno-$LINENO}: "$ac_try""; } >&5 - (eval $ac_try) 2>&5 - ac_status=$? - asecho"as_echo "ase​cho"as_me:${as_lineno-$LINENO}: $? = $ac_status" >&5 - test $ac_status = 0; }; }; then - libc_cv_ppc_rel16=yes -else - libc_cv_ppc_rel16=no -fi -rm -f conftest* -fi -{ asecho"as_echo "ase​cho"as_me:${as_lineno-$LINENO}: result: $libc_cv_ppc_rel16" >&5 -$as_echo "$libc_cv_ppc_rel16" >&6; } -if test $libc_cv_ppc_rel16 = no; then - as_fn_error ?"RPPCREL16isnotsupported.Binutilsistooold.""? "R_PPC_REL16 is not supported. Binutils is too old." "?"RP​PCR​EL16isnotsupported.Binutilsistooold.""LINENO" 5 -fi

See whether GCC uses -msecure-plt.

{ asecho"as_echo "ase​cho"as_me:${as_lineno-$LINENO}: checking for -msecure-plt by default" >&5 $as_echo_n "checking for -msecure-plt by default... " >&6; } diff --git a/sysdeps/powerpc/powerpc32/configure.ac b/sysdeps/powerpc/powerpc32/configure.ac index 21d3f5e..5d3a9b5 100644 --- a/sysdeps/powerpc/powerpc32/configure.ac +++ b/sysdeps/powerpc/powerpc32/configure.ac @@ -1,22 +1,6 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.

Local configure fragment for sysdeps/powerpc/powerpc32.

-# See whether gas has R_PPC_REL16 relocs. -AC_CACHE_CHECK(for R_PPC_REL16 gas support, libc_cv_ppc_rel16, [dnl -cat > conftest.s <<\EOF - .text - addis 11,30,_GLOBAL_OFFSET_TABLE_-.@ha -EOF -if AC_TRY_COMMAND(${CC-cc} -c $CFLAGS conftest.s 1>&AS_MESSAGE_LOG_FD); then - libc_cv_ppc_rel16=yes -else - libc_cv_ppc_rel16=no -fi -rm -f conftest*]) -if test $libc_cv_ppc_rel16 = no; then - AC_MSG_ERROR(R_PPC_REL16 is not supported. Binutils is too old.) -fi

See whether GCC uses -msecure-plt.

AC_CACHE_CHECK(for -msecure-plt by default, libc_cv_ppc_secure_plt, [dnl echo 'int foo (void) { extern int bar; return bar; }' > conftest.c

• References:
  • [PATCH] powerpc: drop R_PPC_REL16 check
    * From: Adhemerval Zanella