[PATCH v3 5/7] x86: Optimize strcmp-avx2.S (original) (raw)
Noah Goldstein goldstein.w.n@gmail.com
Tue Feb 15 13:32:15 GMT 2022
- Previous message (by thread): [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
- Next message (by thread): [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, Feb 15, 2022 at 7:09 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
On Tue, Feb 15, 2022 at 6:58 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > On Tue, Feb 15, 2022 at 6:55 AM Andreas Schwab <schwab@linux-m68k.org> wrote: > > _> > #0 0x00007f4fd4a61df3 in strncmpavx2w (a=0x55aaa1906ffa "tst-tlsmod%", > > b=0x55aaa1940fed "tst-tls-manydynamic73mod", c=10) > > at ../sysdeps/x8664/multiarch/strncmp-avx2w.c:11 > > 11 if (n1 != n2) asm("hlt"); > > I'll check that input thanks! > > One thing, your check has some false positives as all that matters is > n1 / n2 have > same zero/non-zero status or same sign. Confirmed. Sorry for the bug, will ping back when fix is up.
Found a bug (hopefully the bug) in strncmp. Did you see this at all in strcmp-avx2 or was it just the commit you were referencing?
> > > > -- > > Andreas Schwab, schwab@linux-m68k.org > > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > > "And now for something completely different."
- Previous message (by thread): [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
- Next message (by thread): [PATCH v3 5/7] x86: Optimize strcmp-avx2.S
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]