[PATCH resend 2/2] user32/combo: Don't redraw the Combo Box when dropped down if it has an editbox. (original) (raw)
Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Dec 6 09:57:27 CST 2019
- Previous message (by thread): [PATCH resend 1/2] comctl32/combo: Don't redraw the Combo Box when dropped down if it has an editbox.
- Next message (by thread): [PATCH resend 1/2] comctl32/listbox: Set the selection if it's currently invalid in HandleTimer.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Some applications subclass the combo box and handle WM_ERASEBKGND themselves, without using WS_CLIPCHILDREN. This causes them to erase over the editbox child. There's no reason to redraw it in this case since the editbox is supposed to cover it, anyway.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22260 Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
dlls/user32/combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c index ff5ed18..1b193e4 100644 --- a/dlls/user32/combo.c +++ b/dlls/user32/combo.c @@ -1011,7 +1011,7 @@ static void CBDropDown( LPHEADCOMBO lphc ) SWP_NOACTIVATE | SWP_SHOWWINDOW ); - if( !(lphc->wState & CBF_NOREDRAW) ) + if( !(lphc->wState & (CBF_NOREDRAW | CBF_EDIT)) ) RedrawWindow( lphc->self, NULL, 0, RDW_INVALIDATE | RDW_ERASE | RDW_UPDATENOW | RDW_NOCHILDREN );
2.21.0
- Previous message (by thread): [PATCH resend 1/2] comctl32/combo: Don't redraw the Combo Box when dropped down if it has an editbox.
- Next message (by thread): [PATCH resend 1/2] comctl32/listbox: Set the selection if it's currently invalid in HandleTimer.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]