[PATCH 5/5] adsldp/tests: Add some tests for LDAPNamespace. (original) (raw)
Dmitry Timoshkov dmitry at baikal.ru
Mon Dec 16 08:32:41 CST 2019
- Previous message (by thread): [PATCH 5/5] adsldp/tests: Add some tests for LDAPNamespace.
- Next message (by thread): [PATCH] dmloader: Release objects on error paths (Coverity)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Sven Baars <sven.wine at gmail.com> wrote:
On 16-12-2019 15:05, Dmitry Timoshkov wrote: > Sven Baars <sven.wine at gmail.com> wrote: > >>> +STARTTEST(ldap) >>> +{ >>> + HRESULT hr; >>> + >>> + hr = CoInitialize(NULL); >>> + ok(hr == SOK, "got %#x\n", hr); >>> + >>> + testLDAP(); >>> +} >>> >> I think you forgot to call CoUninitialize here. > > The process is going to terminate anyway, so it's a waste of time. > In that case, you might as well remove all *Release calls from your tests...
*_Release calls in the test help to ensure that reference counting works correctly, and I do check that when looking at the logs. However calling CoUninitialize() is meaningless for the test results.
-- Dmitry.
- Previous message (by thread): [PATCH 5/5] adsldp/tests: Add some tests for LDAPNamespace.
- Next message (by thread): [PATCH] dmloader: Release objects on error paths (Coverity)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]