Issue 10137: Patch to IDLE for Python 2.7, at Guido's request (original) (raw)

Created on 2010-10-18 15:54 by Bruce.Sherwood, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
idlelib2.7.patch Bruce.Sherwood,2010-10-18 15:53 patch IDLE 2.7 to address problems
Messages (6)
msg119033 - (view) Author: Bruce Sherwood (Bruce.Sherwood) Date: 2010-10-18 15:53
At Guido's request, I've carried out the same update to the IDLE distributed with Python 2.7 that I submitted for Python 3, to incorporate the work of Guilherme Polo in the Google Summer of Code 2009. Guido was concerned that with significant problems reported for IDLE 2.7, there should be an update despite Python 2.7 itself being essentially frozen. The basic structure for IDLE 3.2 was carried over. The main changes that had to be made were the change in module names between Python 2.7 and Python 3.2 (e.g. Tkinter in 2.7 is tkinter in 3.2).
msg119046 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2010-10-18 17:44
But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it? The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch. Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?
msg119063 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2010-10-18 18:55
I believe the enhancements here are the same as submitted for py3k in Issue10079. Since it is likely the same comments will apply to both variants, I think it would be better to have just one issue, so I would recommend regenerating the patch against the current 2.7 svn top of trunk (or the 2.7 release), attaching the patch to #10079, and closing this as a duplicate.
msg119075 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2010-10-18 20:36
Bruce, what Ned suggests is what I intended with my IDLE-list message, and in accord with usual tracker practice. Issues often apply to multiple versions and thereby require multiple patches and commits. I know you are relatively new at this and very much appreciate you pushing this IDLE update.
msg119095 - (view) Author: Bruce Sherwood (Bruce.Sherwood) Date: 2010-10-18 23:52
Perhaps I've used misleadingt terminology. What I meant is that I did do a diff between IDLE 2.7 and the result of Guilherme Polo's work, but the latter code started from Python 3 code and was modified as needed for 2.7 (e.g. renaming tkinter as Tkinter, etc.) before generating the patch. Bruce Sherwood On Mon, Oct 18, 2010 at 11:44 AM, Amaury Forgeot d'Arc <report@bugs.python.org> wrote: > > Amaury Forgeot d'Arc <amauryfa@gmail.com> added the comment: > > But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it?  The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch. > Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change? > > ---------- > nosy: +amaury.forgeotdarc > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue10137> > _______________________________________ >
msg119117 - (view) Author: Bruce Sherwood (Bruce.Sherwood) Date: 2010-10-19 04:22
I've rebuilt and resubmitted this patch to Issue10079 as requested by Ned Deily. This issue (10137) can now be labeled a duplicate.
History
Date User Action Args
2022-04-11 14:57:07 admin set github: 54346
2010-10-19 04:29:26 terry.reedy set status: open -> closedresolution: duplicatesuperseder: idlelib for Python 3 with Guilherme Polo GSoC enhancements
2010-10-19 04:22:14 Bruce.Sherwood set messages: +
2010-10-18 23:52:41 Bruce.Sherwood set messages: +
2010-10-18 20:36:20 terry.reedy set messages: +
2010-10-18 18:55:25 ned.deily set nosy: + ned.deilymessages: +
2010-10-18 17:44:41 amaury.forgeotdarc set nosy: + amaury.forgeotdarcmessages: +
2010-10-18 17:29:35 brian.curtin set nosy: + terry.reedy
2010-10-18 17:29:14 brian.curtin set nosy: + kbk, taleinat
2010-10-18 15:54:04 Bruce.Sherwood create