Issue 13588: Change name of internal closure functions in importlib (original) (raw)

Created on 2011-12-12 15:32 by brett.cannon, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg149315 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2011-12-12 15:32
The internal closure functions (eg. wrapper functions used by decorators) should not use generic names like inner() or wrapper(), but descriptive names so that they make sense when read in a traceback. IOW, you shouldn't have to look up the source code to figure out what decorator's wrapper is found in the traceback.
msg149479 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2011-12-14 21:21
Thanks for the patch! I will try to find some time to do a proper review if someone else doesn't beat me to it (although first glance seems to suggest it all looks fine).
msg151312 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2012-01-16 00:58
Hi Brett, did you have a chance to review the patch I submitted?
msg151382 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2012-01-16 16:30
Sorry, been busy. I will definitely get to it this week. On Sun, Jan 15, 2012 at 19:58, Berker Peksag <report@bugs.python.org> wrote: > > Berker Peksag <berker.peksag@gmail.com> added the comment: > > Hi Brett, did you have a chance to review the patch I submitted? > > ---------- > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue13588> > _______________________________________ >
msg151389 - (view)	Author: Roundup Robot (python-dev)	Date: 2012-01-16 16:46
New changeset 9935f7837c4b by Brett Cannon in branch 'default': Issue #13588: Rename decorators in importlib. http://hg.python.org/cpython/rev/9935f7837c4b
msg151390 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2012-01-16 16:47
Thanks for the patch, Berker! It's all committed.