| msg57540 - (view) |
Author: Bill Janssen (janssen) *  |
Date: 2007-11-15 17:35 |
| This patch adds the new SSL module to Python 3000, along with the test suite for it. It's against revision 58984. Proper Python indentation has *not* been checked, but leak testing has been done. |
|
|
| msg57543 - (view) |
Author: Christian Heimes (christian.heimes) * |
Date: 2007-11-15 18:31 |
| Ubuntu Linux 7.10, x86, gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2) /home/heimes/dev/python/py3k/Modules/_ssl.c: In function '_get_peer_alt_names': /home/heimes/dev/python/py3k/Modules/_ssl.c:680: warning: passing argument 2 of 'ASN1_item_d2i' from incompatible pointer type /home/heimes/dev/python/py3k/Modules/_ssl.c:684: warning: passing argument 2 of 'method->d2i' from incompatible pointer type gcc -pthread -shared |
|
|
| msg57546 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2007-11-15 18:40 |
| I've tried several different times to fix that warning. It appears on some releases of gcc, and not on others. There seems to be no cast or declaration that fixes it everywhere. More power to you if you can find one! Bill On 11/15/07, Christian Heimes <report@bugs.python.org> wrote: > > Christian Heimes added the comment: > > Ubuntu Linux 7.10, x86, gcc version 4.1.3 20070929 (prerelease) (Ubuntu > 4.1.2-16ubuntu2) > > > /home/heimes/dev/python/py3k/Modules/_ssl.c: In function > '_get_peer_alt_names': > /home/heimes/dev/python/py3k/Modules/_ssl.c:680: warning: passing > argument 2 of 'ASN1_item_d2i' from incompatible pointer type > /home/heimes/dev/python/py3k/Modules/_ssl.c:684: warning: passing > argument 2 of 'method->d2i' from incompatible pointer type > gcc -pthread -shared > > ---------- > nosy: +tiran > > __________________________________ > Tracker <report@bugs.python.org> > <http://bugs.python.org/issue1451> > __________________________________ > |
|
|
| msg57547 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2007-11-15 18:42 |
| Actually, it's some combination of the version of OpenSSL plus the version of gcc. Bill On 11/15/07, Bill Janssen <bill.janssen@gmail.com> wrote: > I've tried several different times to fix that warning. It appears on > some releases of gcc, and not on others. There seems to be no cast or > declaration that fixes it everywhere. More power to you if you can > find one! > > Bill > > On 11/15/07, Christian Heimes <report@bugs.python.org> wrote: > > > > Christian Heimes added the comment: > > > > Ubuntu Linux 7.10, x86, gcc version 4.1.3 20070929 (prerelease) (Ubuntu > > 4.1.2-16ubuntu2) > > > > > > /home/heimes/dev/python/py3k/Modules/_ssl.c: In function > > '_get_peer_alt_names': > > /home/heimes/dev/python/py3k/Modules/_ssl.c:680: warning: passing > > argument 2 of 'ASN1_item_d2i' from incompatible pointer type > > /home/heimes/dev/python/py3k/Modules/_ssl.c:684: warning: passing > > argument 2 of 'method->d2i' from incompatible pointer type > > gcc -pthread -shared > > > > ---------- > > nosy: +tiran > > > > __________________________________ > > Tracker <report@bugs.python.org> > > <http://bugs.python.org/issue1451> > > __________________________________ > > > |
|
|
| msg57553 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2007-11-15 19:40 |
| Looks good (after skimming). Some stylistic nits: - Please fold lines >= 80 chars. - Please strip trailing whitespace (for Python code, you won't be allowed to submit with it present). - You can fold long imports without using the dreaded backslash now, e.g. from _ssl import (SSL_ERROR_ZERO_RETURN, SSL_ERROR_WANT_READ, ...) Then just check it in. (We'll be able to do the dup()'ing differently soon, but I'd just as soon see your patch go in first.) |
|
|
| msg57561 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2007-11-15 20:47 |
| If you haven't checked this in by tomorrow morning, I'll submit issue 1378 (socket3.diff) first, and you'll have to do a bunch of cleanup. Or, if you like, I can submit that now and you can do the cleanup this afternoon. (Basically, we can dup() sockets on Windows now, so all the nonsense about keeping our own reference counts is no longer needed -- makefile() just hangs on to a dup() of the socket. This restores the semantics we had in 1.5.2... |
|
|
| msg57563 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2007-11-15 21:35 |
| I'll check it in this afternoon -- I've just got to figure out how to run the Python clean-up tool. Then you can check in the socket3.diff patch, then I'll make sure the SSL module works with that version of sockets. Bill On 11/15/07, Guido van Rossum <report@bugs.python.org> wrote: > > Guido van Rossum added the comment: > > If you haven't checked this in by tomorrow morning, I'll submit issue > 1378 (socket3.diff) first, and you'll have to do a bunch of cleanup. > Or, if you like, I can submit that now and you can do the cleanup this > afternoon. (Basically, we can dup() sockets on Windows now, so all the > nonsense about keeping our own reference counts is no longer needed -- > makefile() just hangs on to a dup() of the socket. This restores the > semantics we had in 1.5.2... > > __________________________________ > Tracker <report@bugs.python.org> > <http://bugs.python.org/issue1451> > __________________________________ > |
|
|
| msg57568 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2007-11-15 22:24 |
| OK, it's checked in. Let's see what the Windows buildbots think :-). Bill On Nov 15, 2007 1:35 PM, Bill Janssen <report@bugs.python.org> wrote: > > Bill Janssen added the comment: > > I'll check it in this afternoon -- I've just got to figure out how to > run the Python clean-up tool. Then you can check in the socket3.diff > patch, then I'll make sure the SSL module works with that version of > sockets. > > Bill > > On 11/15/07, Guido van Rossum <report@bugs.python.org> wrote: > > > > > Guido van Rossum added the comment: > > > > If you haven't checked this in by tomorrow morning, I'll submit issue > > 1378 (socket3.diff) first, and you'll have to do a bunch of cleanup. > > Or, if you like, I can submit that now and you can do the cleanup this > > afternoon. (Basically, we can dup() sockets on Windows now, so all the > > nonsense about keeping our own reference counts is no longer needed -- > > makefile() just hangs on to a dup() of the socket. This restores the > > semantics we had in 1.5.2... > > > > __________________________________ > > Tracker <report@bugs.python.org> > > <http://bugs.python.org/issue1451> > > __________________________________ > > > > __________________________________ > Tracker <report@bugs.python.org> > <http://bugs.python.org/issue1451> > __________________________________ > |
|
|
| msg57570 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2007-11-15 22:29 |
| Thanks! To be continued in issue 1378... |
|
|
| msg57572 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2007-11-15 23:00 |
| Looks like the Python SVN cert did not get included in the patch, which is causing a failure. I'll check that in. |
|
|