The doc string for url encode states: The query arg may be either a string or a bytes type. When query arg is a string, the safe, encoding and error parameters are sent to the quote_via function for encoding IMHO, this implies that the argument can be a string. Note that the preceding paragraphs starts out with "If the query arg is a sequence of two-element tuples". I think that it should read: The components of the query arg may be either a string or a bytes type. When query arg is a string, the safe, encoding and error parameters are sent to the quote_via function for encoding.
Look good. I'd fix the last line, however: "sent the quote_plus" -> "sent to the quote_plus function", maybe. On Fri, Sep 28, 2012 at 6:18 AM, Brian Brazil <report@bugs.python.org> wrote: > > Brian Brazil added the comment: > > How does the attached patch look? > > I also reworded the first line to be a bit clearer, and be under 80 chars. > > ---------- > keywords: +patch > nosy: +bbrazil > Added file: http://bugs.python.org/file27329/issue15350.patch > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue15350> > _______________________________________
