| msg187887 - (view) |
Author: Andriy Mysyk (amysyk) * |
Date: 2013-04-27 04:55 |
| No need for comma in "which one of the waiting threads proceeds is not defined, and may vary across implementations." "Once a thread has acquired a lock, subsequent attempts to acquire it block, until it is released; any thread may release it" should read "are blocked" instead of "block." /Documents/python/cpython/Doc/build/html/library/threading.html |
|
|
| msg187888 - (view) |
Author: Andriy Mysyk (amysyk) * |
Date: 2013-04-27 05:02 |
| submitting a patch for both grammar errors |
|
|
| msg187907 - (view) |
Author: Ramchandra Apte (Ramchandra Apte) * |
Date: 2013-04-27 14:22 |
| afaik they don't seem to be grammatical errors "subsequent attempts to acquire it block" - block is the verb, don't see anything wrong similar example: the crowd blocks me. (present tense) "which one of the waiting threads proceeds is not defined, and may vary across implementations." - there is only one clause, so no comma needed. If two separate clauses. are separated a coordinating conjunction (such as and), commas are required afaik. |
|
|
| msg187908 - (view) |
Author: Ramchandra Apte (Ramchandra Apte) * |
Date: 2013-04-27 14:26 |
| oops, should be "the crowd blocks me" |
|
|
| msg187909 - (view) |
Author: Andriy Mysyk (amysyk) * |
Date: 2013-04-27 14:48 |
| Ramachandra, if I understand you correctly, I think what you are saying that both are grammar mistakes and the first one could addressed by adding "s" to block. |
|
|
| msg187912 - (view) |
Author: Georg Brandl (georg.brandl) *  |
Date: 2013-04-27 15:27 |
| I see no problem with both points: "block" is the correct verb form in this context ("attempts" being plural), and the version including comma reads better to me. |
|
|
| msg187942 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2013-04-27 22:19 |
| I (as a native English speaker, FWIW) agree that the existing text is correct insofar as the reported problems go. I, however, would remove the comma after 'block'. I don't know that it is wrong as written, but it reads strangely to my ear. |
|
|
| msg188058 - (view) |
Author: Ramchandra Apte (Ramchandra Apte) * |
Date: 2013-04-29 10:02 |
| I'm saying that they aren't valid grammar mistakes (there is no grammar mistake). I agree with Georg Brandl's comment. On 27 April 2013 20:18, Andriy Mysyk <report@bugs.python.org> wrote: > > Andriy Mysyk added the comment: > > Ramachandra, if I understand you correctly, I think what you are saying > that both are grammar mistakes and the first one could addressed by adding > "s" to block. > > ---------- > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue17851> > _______________________________________ > |
|
|