Issue 18551: child_exec() doesn't check return value of fcntl() (original) (raw)
Issue18551
Created on 2013-07-24 19:45 by christian.heimes, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (3) | ||
|---|---|---|
| msg193672 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2013-07-24 19:45 |
| http://hg.python.org/cpython/file/96d817f41c4c/Modules/_posixsubprocess.c#l384 CID 715330 (#2 of 2): Unchecked return value from library (CHECKED_RETURN) 17. check_return: Calling function "fcntl(c2pwrite, 2, old & 0xfffffffffffffffe)" without checking return value. This library function may fail and return an error code. Could this cause any kind of trouble or shall I dismiss the issue as intentional? | ||
| msg242804 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2015-05-09 10:00 |
| Calls to fcntl have been replaced by calls to _Py_set_inheritable so I'd assume that this can be closed as "out of date". | ||
| msg264415 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-04-28 05:17 |
| There is one fcntl call in Modules/_posixsubprocess.c now and its return value is checked local_max_fd = fcntl(0, F_MAXFD); if (local_max_fd >= 0) Closing this as 'out of date'. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:48 | admin | set | github: 62751 |
| 2016-04-28 05:17:11 | berker.peksag | set | status: open -> closednosy: + berker.peksagmessages: + resolution: out of datestage: needs patch -> resolved |
| 2015-05-09 10:00:09 | BreamoreBoy | set | nosy: + BreamoreBoymessages: + versions: + Python 3.5, - Python 3.3 |
| 2013-07-24 19:45:38 | christian.heimes | create |