Issue 19297: test_asyncio: unclosed sockets (original) (raw)
Created on 2013-10-19 13:49 by skrah, last changed 2022-04-11 14:57 by admin. This issue is now closed.
Messages (9)
Author: Stefan Krah (skrah) * 
Date: 2013-10-19 13:49
unittest produces the following resource warnings:
$ ./python -m test -uall test_asyncio [1/1] test_asyncio /home/stefan/hg/master/Lib/unittest/case.py:571: ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=0, laddr=('127.0.0.1', 49177)> testMethod() /home/stefan/hg/master/Lib/unittest/case.py:571: ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=0, laddr=('127.0.0.1', 56385)> testMethod() /home/stefan/hg/master/Lib/unittest/case.py:571: ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=0, laddr=('127.0.0.1', 56244)> testMethod() [...]
It seems to happen whenever run_test_server() from asyncio/test_utils.py is used.
Author: Vajrasky Kok (vajrasky) *
Date: 2013-10-19 14:26
Attached the patch to fix the resource warning problem.
Author: Guido van Rossum (gvanrossum) *
Date: 2013-10-19 16:08
I noticed this previously and was told it wasn't very important. Can I delay the fix until after the alpha 4 release?
Author: Stefan Krah (skrah) *
Date: 2013-10-19 16:18
Yes, the fix can certainly be delayed -- it's just a minor thing that's as little distracting.
Author: Antoine Pitrou (pitrou) *
Date: 2013-10-20 20:11
Since the alpha appears to have been delayed, I think it would be good to commit.
Author: Guido van Rossum (gvanrossum) *
Date: 2013-10-20 21:01
Is there a patch yet?
--Guido van Rossum (sent from Android phone) On Oct 20, 2013 1:11 PM, "Antoine Pitrou" <report@bugs.python.org> wrote:
Antoine Pitrou added the comment:
Since the alpha appears to have been delayed, I think it would be good to commit.
nosy: +pitrou
Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19297>
Author: Antoine Pitrou (pitrou) *
Date: 2013-10-20 21:06
Yes, there is one :)
Author: Guido van Rossum (gvanrossum) *
Date: 2013-10-20 21:22
OK, commit it.
--Guido van Rossum (sent from Android phone) On Oct 20, 2013 2:06 PM, "Antoine Pitrou" <report@bugs.python.org> wrote:
Antoine Pitrou added the comment:
Yes, there is one :)
Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19297>
Author: Roundup Robot (python-dev) 
Date: 2013-10-20 21:26
New changeset 8ad3e9cf9590 by Antoine Pitrou in branch 'default': Close #19297: fix resource warnings in test_asyncio. Patch by Vajrasky Kok. http://hg.python.org/cpython/rev/8ad3e9cf9590
History
Date
User
Action
Args
2022-04-11 14:57:52
admin
set
github: 63496
2013-10-20 21:26:29
python-dev
set
status: open -> closed
nosy: + python-dev
messages: +
resolution: fixed
stage: patch review -> resolved
2013-10-20 21:22:56
gvanrossum
set
messages: +
2013-10-20 21:06:11
pitrou
set
messages: +
2013-10-20 21:01:24
gvanrossum
set
messages: +
2013-10-20 20:11:07
pitrou
set
nosy: + pitrou
messages: +
2013-10-19 16🔞20
skrah
set
messages: +
2013-10-19 16:08:19
gvanrossum
set
messages: +
2013-10-19 14:56:38
pitrou
set
nosy: + gvanrossum
type: resource usage
stage: patch review
2013-10-19 14:26:28
vajrasky
set
files: + close_httpd_server_in_asyncio_test_utils.patch
nosy: + vajrasky
messages: +
keywords: + patch
2013-10-19 13:49:32
skrah
create