original ) (raw ) Issue22784
Created on 2014-11-02 16:20 by pitrou , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Messages (5)
msg230502 - (view) Author: Antoine Pitrou (pitrou) *
Date: 2014-11-02 16:20
Patch attached. I don't know whether this applies to 3.4 as well.
msg230528 - (view) Author: Guido van Rossum (gvanrossum) *
Date: 2014-11-03 03:10
Is something missing from the patch? I don't understand how *not* defining a function can make anything better. Perhaps you need to conditionally skip the test that uses it?
msg230531 - (view) Author: Antoine Pitrou (pitrou) *
Date: 2014-11-03 10:13
The problem is the default value for `purpose` in the function declaration (the signature mocks the ssl.create_default_context() function, so I don't think it's ok to change the default parameter value here).
msg230543 - (view) Author: Guido van Rossum (gvanrossum) *
Date: 2014-11-03 15:54
OK, them LGTM.
msg230710 - (view) Author: Roundup Robot (python-dev)
Date: 2014-11-05 19:50
New changeset 7e9e2b17ac6f by Antoine Pitrou in branch '3.4': Closes #22784 : fix test_asyncio when the ssl module isn't available https://hg.python.org/cpython/rev/7e9e2b17ac6f New changeset 028c729714af by Antoine Pitrou in branch 'default': Closes #22784 : fix test_asyncio when the ssl module isn't available https://hg.python.org/cpython/rev/028c729714af
History
Date
User
Action
Args
2022-04-11 14:58:09
admin
set
github: 66973
2014-11-05 19:50:11
python-dev
set
status: open -> closednosy: + python-dev messages: + resolution: fixedstage: patch review -> resolved
2014-11-03 15:54:24
gvanrossum
set
messages: +
2014-11-03 10:13:11
pitrou
set
messages: +
2014-11-03 03:10:01
gvanrossum
set
messages: +
2014-11-02 16:20:57
pitrou
create
