Issue 22788: allow logging.handlers.HTTPHandler to take an SSLContext (original) (raw)

Created on 2014-11-03 18:49 by benjamin.peterson, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue22788.diff alex,2014-11-03 20:00 review
Messages (7)
msg230549 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2014-11-03 18:49
It would be nice if HTTPHandler could take an SSLContext as a parameter, which would be passed to HTTPSConnection to configure the security of the connection.
msg230551 - (view) Author: Alex Gaynor (alex) * (Python committer) Date: 2014-11-03 19:33
I'm not sure I follow, where does HTTPHandler ever construct an HTTPSConnection?
msg230552 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2014-11-03 19:33
emit() On Mon, Nov 3, 2014, at 15:33, Alex Gaynor wrote: > > Alex Gaynor added the comment: > > I'm not sure I follow, where does HTTPHandler ever construct an > HTTPSConnection? > > ---------- > nosy: +alex > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue22788> > _______________________________________
msg230553 - (view) Author: Alex Gaynor (alex) * (Python committer) Date: 2014-11-03 19:37
Hah! I didn't realize you meant *logging.handlers.HTTPHandler*, I thought you meant *urllib.request.HTTPHandler*.
msg230555 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2014-11-03 19:37
Right then...
msg230558 - (view) Author: Alex Gaynor (alex) * (Python committer) Date: 2014-11-03 20:00
Quick pass at a patch. No docs, and it should proabbly be an error to pass context with secure=False.
msg231589 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-24 02:38
New changeset 5864ec6ba484 by Benjamin Peterson in branch '3.4': add context parameter to HTTPHandler (closes #22788) https://hg.python.org/cpython/rev/5864ec6ba484 New changeset ec4d19736b15 by Benjamin Peterson in branch 'default': merge 3.4 (#22788) https://hg.python.org/cpython/rev/ec4d19736b15
History
Date User Action Args
2022-04-11 14:58:09 admin set github: 66977
2014-11-24 02:38:30 python-dev set status: open -> closednosy: + python-devmessages: + resolution: fixedstage: needs patch -> resolved
2014-11-03 23:49:31 Arfrever set nosy: + Arfrever
2014-11-03 20:00:58 alex set keywords: + patch, needs reviewfiles: + issue22788.diffmessages: +
2014-11-03 19:37:43 benjamin.peterson set messages: + title: allow HTTPHandler to take an SSLContext -> allow logging.handlers.HTTPHandler to take an SSLContext
2014-11-03 19:37:18 alex set messages: +
2014-11-03 19:33:43 benjamin.peterson set messages: +
2014-11-03 19:33:14 alex set nosy: + alexmessages: +
2014-11-03 18:49:27 benjamin.peterson create