Issue 25786: contextlib.ExitStack introduces a cycle in exception context (original) (raw)

Created on 2015-12-02 19:58 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
Issue25786.patch yselivanov,2015-12-02 19:59 review
Messages (6)
msg255762 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-12-02 19:58
See http://bugs.python.org/issue25779 and http://bugs.python.org/issue25782 for details.
msg255764 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-12-02 19:59
Nick, could you please take a look at the attached patch?
msg255798 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-12-03 00:46
If I understand this issue correctly, perhaps the test case should be augmented to check for a cycle: try: main() except RuntimeError as exc: self.assertIsNone(exc.__cause__) else: self.fail("Expected RuntimeError")
msg255994 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-12-06 00:44
I don't agree that a reference cycle counts as a release blocker.
msg255999 - (view) Author: Yury Selivanov (Yury.Selivanov) * Date: 2015-12-06 02:20
This cycle leads to infinite unbreakable loop in cpython c internals. Sent from my iPhone > On Dec 5, 2015, at 7:44 PM, Larry Hastings <report@bugs.python.org> wrote: > > > Larry Hastings added the comment: > > I don't agree that a reference cycle counts as a release blocker. > > ---------- > nosy: +larry > priority: release blocker -> normal > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue25786> > _______________________________________
msg391592 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-04-22 12:12
Looks like it was fixed in contextlib here: https://github.com/python/cpython/commit/ba2ecd68414b9c53d00560579f5bc13459bc0449
History
Date User Action Args
2022-04-11 14:58:24 admin set github: 69972
2021-04-22 14:34:16 iritkatriel set status: pending -> closedsuperseder: Hang with contextlib.ExitStack and subprocess.Popen (regression)resolution: fixed -> duplicatestage: resolved
2021-04-22 12:12:02 iritkatriel set status: open -> pendingnosy: + iritkatrielmessages: + resolution: fixed
2015-12-06 02:20:14 Yury.Selivanov set nosy: + Yury.Selivanovmessages: +
2015-12-06 00:44:18 larry set priority: release blocker -> normalnosy: + larrymessages: +
2015-12-03 00:46:38 martin.panter set nosy: + martin.pantermessages: +
2015-12-02 20:06:12 oconnor663 set nosy: + oconnor663
2015-12-02 19:59:54 yselivanov set files: + Issue25786.patchkeywords: + patchmessages: +
2015-12-02 19:58:45 yselivanov create