Issue 26125: Incorrect error message in the module asyncio.selector_events. (original) (raw)

Created on 2016-01-15 13:52 by Paradisee, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (7)
msg258294 - (view)	Author: Carlo Beccarini (Paradisee) *	Date: 2016-01-15 13:52
Incorrect error message in the module asyncio.selector_events for the methods: _SelectorSocketTransport.write _SelectorSslTransport.write _SelectorDatagramTransport.sendto. The previous error was raising a Tuple: TypeError: ('data argument must be byte-ish (%r)', <class 'str'>) Patched: TypeError: data argument must be a bytes-like object, not 'str'
msg258296 - (view)	Author: Ezio Melotti (ezio.melotti) *	Date: 2016-01-15 14:03
LGTM unless you think we should also add a test that checks that the name of the incorrect type is included in the error message.
msg258301 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2016-01-15 16:01
Remember also to apply to asyncio's own GitHub repo. --Guido (mobile) On Jan 15, 2016 6:03 AM, "Ezio Melotti" <report@bugs.python.org> wrote: > > Ezio Melotti added the comment: > > LGTM unless you think we should also add a test that checks that the name > of the incorrect type is included in the error message. > > ---------- > nosy: +ezio.melotti > stage: -> commit review > type: -> behavior > versions: +Python 3.5, Python 3.6 -Python 3.4 > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue26125> > _______________________________________ >
msg258307 - (view)	Author: Carlo Beccarini (Paradisee) *	Date: 2016-01-15 16:45
https://github.com/python/asyncio/pull/313
msg259203 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2016-01-29 10:06
https://github.com/python/asyncio/pull/313 has been merged. Do we need to commit this patch to the CPython repo or will it be merged with the next sync? (e.g. f4fe55dd5659)
msg259211 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2016-01-29 15:43
Usually Yury or Victor takes care of this sooner or later. If you want to you can keep this open as a release blocker with that as a task.
msg259338 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2016-02-01 17:57
Victor committed this in 97c80e317ab8 (3.5) and c7f1acdd8be1 (default). Closing as "fixed".