| msg266696 - (view) |
Author: Kenneth Lim (Kenneth Lim) |
Date: 2016-05-30 14:52 |
| Passing a dict with colon-containing keys as kwargs to a function results in a KeyError stemming from a silent truncation of the keys. Error does not clearly describe the issue in this case. |
|
|
| msg266697 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2016-05-30 14:56 |
| IMHO the error is very explicit: Traceback (most recent call last): File "poc.py", line 6, in print(a.format(**r)) KeyError: 'HGNC' Your "r" directory has no "HGNC" key. I think that you misunderstood the formatting of str.format: https://docs.python.org/dev/library/string.html#formatstrings The format string "{HGNC:11892}" is parsed as key="HGNC", format="11892". |
|
|
| msg266698 - (view) |
Author: Anilyka Barry (abarry) *  |
Date: 2016-05-30 15:02 |
| In other words, you cannot use keys containing a colon in str.format - you'll need to replace the colons by something else (for example an underscore, that works fine). |
|
|
| msg266703 - (view) |
Author: Kenneth Lim (Kenneth Lim) |
Date: 2016-05-30 16:19 |
| Hi Barry, I was aware of that. However, I was alluding to the KeyError produced, and the silent truncation of the text. Rather than failing at the colon step (SyntaxError when on run), truncated arguments pass this step, causing errors downstream. On Mon, May 30, 2016 at 11:02 PM, Emanuel Barry <report@bugs.python.org> wrote: > > Emanuel Barry added the comment: > > In other words, you cannot use keys containing a colon in str.format - > you'll need to replace the colons by something else (for example an > underscore, that works fine). > > ---------- > nosy: +ebarry > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue27160> > _______________________________________ > |
|
|
| msg266707 - (view) |
Author: Anilyka Barry (abarry) * |
Date: 2016-05-30 16:37 |
| The behaviour is correct, it's your assumptions that aren't :) The code for str.format only checks for what's before the colon (here, "HGNC") and checks if that's part of the dict provided. It isn't, so it raises a KeyError. It doesn't even get to the format spec part (which is a perfectly valid format specifier). Your dict can contain anything or be empty, str.format only checks for the existence of the key you asked for ("HGNC"). "{HGNC:11892}" is also a perfectly valid Python string. P.S.: While I'm fine with people calling me by my last name, there's another developer whose name is Barry Warsaw, so let's try to avoid confusion here ;-) |
|
|
| msg266709 - (view) |
Author: Kenneth Lim (Kenneth Lim) |
Date: 2016-05-30 16:58 |
| Ah, so the truncation is fully intended behavior. As for the name, a touch too many comic-books in the past might be the reason I latched onto "Barry" as a first name. Thanks for the clarification. On Tue, May 31, 2016 at 12:37 AM, Emanuel Barry <report@bugs.python.org> wrote: > > Emanuel Barry added the comment: > > The behaviour is correct, it's your assumptions that aren't :) > > The code for str.format only checks for what's before the colon (here, > "HGNC") and checks if that's part of the dict provided. It isn't, so it > raises a KeyError. It doesn't even get to the format spec part (which is a > perfectly valid format specifier). Your dict can contain anything or be > empty, str.format only checks for the existence of the key you asked for > ("HGNC"). "{HGNC:11892}" is also a perfectly valid Python string. > > P.S.: While I'm fine with people calling me by my last name, there's > another developer whose name is Barry Warsaw, so let's try to avoid > confusion here ;-) > > ---------- > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue27160> > _______________________________________ > |
|
|