Issue 27679: set_bitfields() unused in _ctypes_test (original) (raw)

Issue27679

Created on 2016-08-04 08:32 by martin.panter, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14648 merged shihai1991,2019-07-08 17:25
Messages (3)
msg271956 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-08-04 08:32
Modules/_ctypes/_ctypes_test.c defines a structure called BITS and exports two C functions set_bitfields() and unpack_bitfields() that operate on it. However only unpack_bitfields() seems to have been used, in Lib/ctypes/test/test_bitfields.py. Either there is scope for enhancing the tests, or maybe there is no point and the function can be removed.
msg347569 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-07-09 18:00
New changeset 3a3db970de344efbb4017fb9dde9204f0fd4bbdc by Victor Stinner (Hai Shi) in branch 'master': bpo-27679: Remove set_bitfields() from _ctypes_test (GH-14648) https://github.com/python/cpython/commit/3a3db970de344efbb4017fb9dde9204f0fd4bbdc
msg347570 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-07-09 18:02
I don't feel the need to backport the change to Python 3.8 and older. Having an unused in a test module (_ctypes_test) doesn't hurt. I close the issue. Thanks Martin Panter for the report, thanks Hai Shi for the fix ;-)
History
Date User Action Args
2022-04-11 14:58:34 admin set github: 71866
2019-07-09 18:02:05 vstinner set status: open -> closedversions: + Python 3.9messages: + resolution: fixedstage: patch review -> resolved
2019-07-09 18:00:32 vstinner set nosy: + vstinnermessages: +
2019-07-08 17:31:53 shihai1991 set nosy: + shihai1991versions: - Python 3.6
2019-07-08 17:25:14 shihai1991 set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest14459>
2019-04-17 20:15:57 nanjekyejoannah set nosy: + nanjekyejoannah
2016-08-04 08:32:36 martin.panter create