Issue 30989: Sort only when needed in TimedRotatingFileHandler's getFilesToDelete (original) (raw)

Issue30989

Created on 2017-07-22 07:17 by Lovesh Harchandani, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg298839 - (view)	Author: Lovesh Harchandani (Lovesh Harchandani) *	Date: 2017-07-22 07:17
At `/Lib/logging/handlers.py` in `TimedRotatingFileHandler`'s `getFilesToDelete` method, filenames are sorted using `result.sort()` regardless of `len(result)`, if `len(result)` < backupCount, sorting is not required.
msg305104 - (view)	Author: Vinay Sajip (vinay.sajip) *	Date: 2017-10-27 07:04
New changeset afad147b59fe84b12317f7340ddd2deeecb22321 by Vinay Sajip (Lovesh Harchandani) in branch 'master': bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812) https://github.com/python/cpython/commit/afad147b59fe84b12317f7340ddd2deeecb22321
msg306508 - (view)	Author: Vinay Sajip (vinay.sajip) *	Date: 2017-11-19 18:43
New changeset 65dffe58dd062385024eacbe75a0fa59ec12a993 by Vinay Sajip (Miss Islington (bot)) in branch '3.6': bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812) (GH-4466) https://github.com/python/cpython/commit/65dffe58dd062385024eacbe75a0fa59ec12a993

History
Date	User	Action	Args
2022-04-11 14:58:49	admin	set	github: 75172
2017-11-19 22:28:03	vinay.sajip	set	status: open -> closedresolution: fixedstage: patch review -> resolved
2017-11-19 18:43:51	vinay.sajip	set	messages: +
2017-11-19 18:06:57	python-dev	set	keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest4399>
2017-10-27 07:04:35	vinay.sajip	set	messages: +
2017-10-26 22:17:00	berker.peksag	set	nosy: + vinay.sajip
2017-07-22 07:56:38	Lovesh Harchandani	set	pull_requests: + <pull%5Frequest2863>
2017-07-22 07🔞53	Lovesh Harchandani	set	components: + Library (Lib)
2017-07-22 07🔞34	Lovesh Harchandani	set	type: enhancement
2017-07-22 07:17:22	Lovesh Harchandani	create