bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-281… · python/cpython@65dffe5 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Commit 65dffe5

miss-islingtonvsajip

authored and

committed

TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed. (cherry picked from commit afad147)

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -356,10 +356,10 @@ def getFilesToDelete(self):
356 356 suffix = fileName[plen:]
357 357 if self.extMatch.match(suffix):
358 358 result.append(os.path.join(dirName, fileName))
359 -result.sort()
360 359 if len(result) < self.backupCount:
361 360 result = []
362 361 else:
362 +result.sort()
363 363 result = result[:len(result) - self.backupCount]
364 364 return result
365 365