Issue 3212: ssl module - should test for a wrong cert (original) (raw)

Created on 2008-06-26 18:34 by jonas.wagner, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (7)
msg68797 - (view)	Author: Jonas Wagner (jonas.wagner)	Date: 2008-06-26 18:34
Currently test_ssl.py only tests for empty or broken certificates. One can break certificate validation in _ssl.c and they still pass. The following patch should fix this. - Jonas
msg68807 - (view)	Author: Bill Janssen (janssen) *	Date: 2008-06-26 22:53
OK, good idea. I'll put it in. Bill On Thu, Jun 26, 2008 at 11:34 AM, Jonas Wagner <report@bugs.python.org> wrote: > > New submission from Jonas Wagner <veers@gmx.ch>: > > Currently test_ssl.py only tests for empty or broken certificates. One > can break certificate validation in _ssl.c and they still pass. > > The following patch should fix this. > > - Jonas > > ---------- > components: Tests > files: add_wrong_cert_test.diff > keywords: patch > messages: 68797 > nosy: janssen, jonas.wagner > severity: normal > status: open > title: ssl module - should test for a wrong cert > type: feature request > versions: Python 2.6 > Added file: http://bugs.python.org/file10745/add_wrong_cert_test.diff > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue3212> > _______________________________________ >
msg68912 - (view)	Author: Bill Janssen (janssen) *	Date: 2008-06-28 21:24
I've added this into my patch.
msg68930 - (view)	Author: Bill Janssen (janssen) *	Date: 2008-06-29 00:03
Added this in 2.6, still needs it for 3.x.
msg92107 - (view)	Author: Daniel Black (grooverdan) *	Date: 2009-08-31 07:39
Is fixed in p3k Mon Sep 8 16:45:19 2008 UTC http://svn.python.org/view/python/branches/py3k/Lib/test/test_ssl.py?r1=65837&r2=66311
msg93046 - (view)	Author: Thijs Triemstra (thijs)	Date: 2009-09-23 17:47
Guess it can be closed then.
msg104370 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2010-04-27 21:42
Ok, so it was fixed.