Issue 3899: test_ssl.py doesn't properly test ssl integration with asyncore (original) (raw)

Created on 2008-09-18 13:35 by giampaolo.rodola, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg73382 - (view)	Author: Giampaolo Rodola' (giampaolo.rodola) *	Date: 2008-09-18 13:35
The AsyncoreEchoServer class in test_ssl.py doesn't actually test a real integration with asyncore since the do_handshake_on_connect flag is set to True and hence temporarily blocks the asyncore polling loop as long as the ssl handshake finishes. The patch in attachment subclasses some asyncore internals so that a non-blocking ssl handshake takes place. Tested under Windows XP SP3, Python 2.6rc1.
msg73398 - (view)	Author: Bill Janssen (janssen) *	Date: 2008-09-18 20:50
The server wasn't meant to be non-blocking. The non-blocking test is performed when the client (which is non-blocking) connects to it.
msg73417 - (view)	Author: Josiah Carlson (josiahcarlson) *	Date: 2008-09-19 02:33
Being able to test the async features of both sides of the SSL connection is a good thing. Also, the subclass provides a useful example for users who want to use asyncore and ssl servers without blocking on an incoming connection.
msg73441 - (view)	Author: Bill Janssen (janssen) *	Date: 2008-09-19 20:29
Sure, no argument. I was just making clear what was going on. Bill On Thu, Sep 18, 2008 at 7:33 PM, Josiah Carlson <report@bugs.python.org>wrote: > > Josiah Carlson <josiahcarlson@users.sourceforge.net> added the comment: > > Being able to test the async features of both sides of the SSL > connection is a good thing. > > Also, the subclass provides a useful example for users who want to use > asyncore and ssl servers without blocking on an incoming connection. > > _______________________________________ > Python tracker <report@bugs.python.org> > <http://bugs.python.org/issue3899> > _______________________________________ >
msg115551 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2010-09-04 00:35
This has been integrated long ago.