Add version information to jvmti demos. (original) (raw)

Neil Richards neil.richards at ngmr.net
Thu Sep 15 18:51:35 UTC 2011

On Thu, 2011-09-15 at 12:14 -0400, Zhengyu Gu wrote:

No progress been made. Any reason should be resolved right away?

Thanks, -Zhengyu On 9/15/2011 2:50 AM, Sean Chou wrote: > Hi, > About this bug, is there any progressing ? > > > 2011/6/8 Zhengyu Gu <zhengyu.gu at oracle.com> > No, I did not make any progress on 6988099, as it was > deferred to JDK8. With Dan's comment, looks good to me. > > Thanks, > > -Zhengyu

I've made a couple of modifications to Sean's suggested change, in response to Dan's comments:

  * For Windows, added '$(DEMO_VERSION_INFO)' to 'LDLIBS.demo', so
    that the line of the link command doesn't need to be modified,
    and so 'DEMO_VERSION_INFO' isn't used outside a windows-specific
    context.
  * Wrapped the definition of 'RC_FLAGS' in a windows-specific
    block.

I've uploaded the resulting webrev for your review and blessing [1].

If you're happy with change, I'll look to commit it up into jdk8/build/jdk

Regards, Neil

[1] http://cr.openjdk.java.net/~ngmr/6988099/webrev.00

-- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

More information about the build-dev mailing list